Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return standardized text for ready and health endpoint #3195

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@xieyanker
Copy link
Contributor

commented Aug 26, 2019

return standardized text for ready and health endpoint

@corbot corbot bot requested a review from chrisohaver Aug 26, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked chrisohaver (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@miekg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

the string "OK" is also used in health_test.go

@xieyanker xieyanker force-pushed the xieyanker:xieyanker-patch-2 branch from 5783188 to 227cd68 Aug 26, 2019

@xieyanker xieyanker force-pushed the xieyanker:xieyanker-patch-2 branch from 227cd68 to 835da64 Aug 26, 2019

@xieyanker

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@miekg done!

@miekg

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@corbot
corbot bot approved these changes Aug 26, 2019
Copy link

left a comment

LGTM by miekg

@codecov-io

This comment has been minimized.

Copy link

commented Aug 26, 2019

Codecov Report

Merging #3195 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3195   +/-   ##
======================================
  Coverage    55.8%   55.8%           
======================================
  Files         206     206           
  Lines       10419   10419           
======================================
  Hits         5814    5814           
  Misses       4186    4186           
  Partials      419     419
Impacted Files Coverage Δ
plugin/ready/ready.go 86.2% <100%> (ø) ⬆️
plugin/health/health.go 78.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8238b...835da64. Read the comment docs.

@miekg miekg merged commit 9fe7fb9 into coredns:master Aug 26, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.8% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.