Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/file: close reader for reload #3196

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@miekg
Copy link
Member

commented Aug 26, 2019

This reloader didn't close the openened file handle. Add a close. Can't
use defer because this is in a endless loop.

Fixes: #3191

plugin/file: close reader for reload
This reloader didn't close the openened file handle. Add a close. Can't
use `defer` because this is in a endless loop.

Fixes: #3191

Signed-off-by: Miek Gieben <miek@miek.nl>

@corbot corbot bot requested a review from yongtang Aug 26, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked yongtang (via plugin/file/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@miekg

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

not fully certain if this really fixes the issue, but we do need to close this handle

@miekg miekg merged commit aeb27bd into master Aug 26, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the close-handles branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.