Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/file: less notify logging spam #3212

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@miekg
Copy link
Member

commented Aug 27, 2019

Say once that we've sent notifies, instead of for every upstream
primary.

plugin/file: less notify logging spam
Say once that we've sent notifies, instead of for every upstream
primary.

Signed-off-by: Miek Gieben <miek@miek.nl>

@corbot corbot bot requested a review from yongtang Aug 27, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 27, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked yongtang (via plugin/file/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #3212 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3212      +/-   ##
==========================================
+ Coverage   55.79%   55.81%   +0.02%     
==========================================
  Files         206      206              
  Lines       10419    10418       -1     
==========================================
+ Hits         5813     5815       +2     
+ Misses       4187     4184       -3     
  Partials      419      419
Impacted Files Coverage Δ
plugin/file/notify.go 38.46% <100%> (+3.46%) ⬆️
plugin/file/reload.go 69.44% <0%> (-5.56%) ⬇️
plugin/clouddns/clouddns.go 85.45% <0%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f491880...069cc7b. Read the comment docs.

@miekg miekg merged commit 87bd9de into master Aug 27, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.81% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the less-notifies branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.