Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/file: rework outgoing axfr #3227

Merged
merged 4 commits into from Aug 30, 2019

Conversation

@miekg
Copy link
Member

commented Aug 29, 2019

No description provided.

plugin/file: rework outgoing axfr
Signed-off-by: Miek Gieben <miek@miek.nl>
Fix test
Signed-off-by: Miek Gieben <miek@miek.nl>
Actually properly test xfr
Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io

This comment has been minimized.

Copy link

commented Aug 29, 2019

Codecov Report

Merging #3227 into master will decrease coverage by 0.1%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage   55.83%   55.72%   -0.11%     
==========================================
  Files         206      213       +7     
  Lines       10417    10747     +330     
==========================================
+ Hits         5816     5989     +173     
- Misses       4183     4303     +120     
- Partials      418      455      +37
Impacted Files Coverage Δ
plugin/file/xfr.go 0% <0%> (ø) ⬆️
plugin/file/zone.go 69.38% <45.45%> (-1.77%) ⬇️
plugin/sign/file.go 57.14% <0%> (ø)
plugin/sign/sign.go 0% <0%> (ø)
plugin/sign/signer.go 51.3% <0%> (ø)
plugin/sign/dnssec.go 100% <0%> (ø)
plugin/sign/nsec.go 72.22% <0%> (ø)
plugin/sign/setup.go 64.17% <0%> (ø)
plugin/sign/keys.go 40.32% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec24cb...834141f. Read the comment docs.

@stp-ip
Copy link
Member

left a comment

/lgtm

One change request within the test. Rest looks good.

test/auto_test.go Outdated Show resolved Hide resolved
Fix test
Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg changed the title WIP: plugin/file: rework outgoing axfr plugin/file: rework outgoing axfr Aug 30, 2019

@corbot corbot bot requested a review from grobie Aug 30, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 30, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked grobie (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@miekg miekg merged commit 94930d2 into master Aug 30, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.72% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the pfile branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.