Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: add logo #3230

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@miekg
Copy link
Member

commented Aug 30, 2019

As discussed in #3225, lets add a little logo. This PR incorperates this
in the startup text. It also removes the logging output as this outputs
identical lines of text, but for no clear reason. This means --quiet now
means "no output on startup at all".

Currently it looks like this:

.:1053
   ______                ____  _   _______
  / ____/___  ________  / __ \/ | / / ___/	~ CoreDNS-1.6.2
 / /   / __ \/ ___/ _ \/ / / /  |/ /\__ \ 	~ linux/amd64, go1.12.9,
/ /___/ /_/ / /  /  __/ /_/ / /|  /___/ /
\____/\____/_/   \___/_____/_/ |_//____/

We have 2 lines extra on the right if we need to print more (no ideas
come to mind currently).

startup: add logo
As discussed in #3225, lets add a little logo. This PR incorperates this
in the startup text. It also removes the logging output as this outputs
identical lines of text, but for no clear reason. This means --quiet now
means "no output on startup at all".

Currently it looks like this:

~~~
.:1053
   ______                ____  _   _______
  / ____/___  ________  / __ \/ | / / ___/	CoreDNS-1.6.2
 / /   / __ \/ ___/ _ \/ / / /  |/ /\__ \ 	linux/amd64, go1.12.9,
/ /___/ /_/ / /  /  __/ /_/ / /|  /___/ /
\____/\____/_/   \___/_____/_/ |_//____/
~~~

We have 2 lines extra on the right if we need to print more (no ideas
come to mind currently).

Signed-off-by: Miek Gieben <miek@miek.nl>

@corbot corbot bot requested a review from stp-ip Aug 30, 2019

@corbot

This comment has been minimized.

Copy link

commented Aug 30, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked stp-ip (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #3230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3230   +/-   ##
=======================================
  Coverage   55.78%   55.78%           
=======================================
  Files         213      213           
  Lines       10747    10747           
=======================================
  Hits         5995     5995           
  Misses       4297     4297           
  Partials      455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a0b52...e2243e8. Read the comment docs.

@thaJeztah

This comment has been minimized.

Copy link

commented Aug 30, 2019

perhaps put the version information on their own line after the logo, for easier grep-ing and for small terminals?

(perhaps put the logo on stderr to allow redirecting it)

@miekg

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Add distinct marker for grep and cut purposes
Signed-off-by: Miek Gieben <miek@miek.nl>

@miekg miekg merged commit c466003 into master Aug 30, 2019

4 checks passed

ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.78% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@corbot corbot bot deleted the startup-logging branch Aug 30, 2019

@mrueg

This comment has been minimized.

Copy link

commented Aug 31, 2019

ASCII logos could cause issues and difficulties in terms of accessibility. Has this been tested on screenreaders / other devices?

@towolf

This comment has been minimized.

Copy link

commented Sep 16, 2019

Redis does this:

# By default Redis shows an ASCII art logo only when started to log to the
# standard output and if the standard output is a TTY. Basically this means
# that normally a logo is displayed only in interactive sessions.
#
# However it is possible to force the pre-4.0 behavior and always show a
# ASCII art logo in startup logs by setting the following option to yes.
always-show-logo yes

Why? Because multi-line logos look shitty in logging systems where one line is taken to be one message.

@coredns coredns locked as resolved and limited conversation to collaborators Sep 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.