Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/kubernetes: Don't duplicate service records in zone transfer #3240

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@chrisohaver
Copy link
Member

commented Sep 5, 2019

1. Why is this pull request needed and what does it do?

Noticed this while working on the new transfer plugin (#3223). The existing kubernetes transfer code creates a duplicate service A/AAAA record for every port the service defines. AFAIK, zone transfer recipients should tolerate duplicate records in a zone transfer, but it does make the transfer larger than it needs to be.

2. Which issues (if any) are related?

None

3. Which documentation changes (if any) need to be made?

None

4. Does this introduce a backward incompatible change or deprecation?

No

@corbot corbot bot requested a review from yongtang Sep 5, 2019
@corbot

This comment has been minimized.

Copy link

commented Sep 5, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked yongtang (via plugin/kubernetes/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #3240 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
- Coverage    56.1%   56.08%   -0.02%     
==========================================
  Files         215      215              
  Lines       10898    10899       +1     
==========================================
- Hits         6114     6113       -1     
- Misses       4327     4328       +1     
- Partials      457      458       +1
Impacted Files Coverage Δ
plugin/kubernetes/xfr.go 88.42% <100%> (+0.09%) ⬆️
plugin/file/reload.go 69.44% <0%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630d3d6...4fe20ed. Read the comment docs.

@chrisohaver chrisohaver requested a review from bradbeam Sep 6, 2019
@miekg miekg merged commit 70f2bd1 into coredns:master Sep 8, 2019
4 checks passed
4 checks passed
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.08% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.