Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
plugin/kubernetes: Don't duplicate service records in zone transfer #3240
1. Why is this pull request needed and what does it do?
Noticed this while working on the new transfer plugin (#3223). The existing kubernetes transfer code creates a duplicate service A/AAAA record for every port the service defines. AFAIK, zone transfer recipients should tolerate duplicate records in a zone transfer, but it does make the transfer larger than it needs to be.
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked yongtang (via
@@ Coverage Diff @@ ## master #3240 +/- ## ========================================== - Coverage 56.1% 56.08% -0.02% ========================================== Files 215 215 Lines 10898 10899 +1 ========================================== - Hits 6114 6113 -1 - Misses 4327 4328 +1 - Partials 457 458 +1