Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move map to array #3339

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@miekg
Copy link
Member

miekg commented Oct 1, 2019

The map was not needed move to an array, see #1941 for the original
idea. That of course didn't apply anymore; make a super minimal change
to implements the idea from #1941

The map was not needed move to an array, see #1941 for the original
idea. That of course didn't apply anymore; make a super minimal change
to implements the idea from #1941

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from grobie Oct 1, 2019
@corbot

This comment has been minimized.

Copy link

corbot bot commented Oct 1, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked grobie (via plugin/forward/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@miekg miekg added the plugin/forward label Oct 1, 2019
@miekg miekg removed the request for review from grobie Oct 1, 2019
@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Oct 1, 2019

cc @drozhdzh (original PR was conflicting too much)

Copy link
Contributor

rdrozhdzh left a comment

Overall looks good to me. Thanks for picking this up.
Is the test failure related to this change?

plugin/forward/persistent.go Outdated Show resolved Hide resolved
plugin/forward/persistent.go Outdated Show resolved Hide resolved
Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #3339 into master will increase coverage by 0.01%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3339      +/-   ##
=========================================
+ Coverage   55.18%   55.2%   +0.01%     
=========================================
  Files         216     217       +1     
  Lines       10772   10783      +11     
=========================================
+ Hits         5945    5953       +8     
- Misses       4369    4371       +2     
- Partials      458     459       +1
Impacted Files Coverage Δ
plugin/forward/persistent.go 96.96% <100%> (+1.25%) ⬆️
plugin/forward/type.go 86.66% <86.66%> (ø)
plugin/file/reload.go 69.44% <0%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d98d52...dae9b55. Read the comment docs.

@miekg miekg merged commit 575cea4 into master Oct 1, 2019
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.2% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@corbot corbot bot deleted the remove-map branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.