Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/route53: remove amazon intialization from init #3348

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@miekg
Copy link
Member

miekg commented Oct 2, 2019

Don't perform this code in the init, this allocated 1 megabyte of memory
even if you don't use the plugin. Looks to be only there for testing,
adding a comment to reflect that.

Fixes #3342

Don't perform this code in the init, this allocated 1 megabyte of memory
even if you don't use the plugin. Looks to be only there for testing,
adding a comment to reflect that.

Fixes #3342

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from dilyevsky Oct 2, 2019
@corbot

This comment has been minimized.

Copy link

corbot bot commented Oct 2, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked dilyevsky (via plugin/route53/OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Oct 2, 2019

similar in vain, so /cc @yongtang

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #3348 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
+ Coverage   55.22%   55.26%   +0.03%     
==========================================
  Files         217      217              
  Lines       10788    10783       -5     
==========================================
+ Hits         5958     5959       +1     
+ Misses       4371     4367       -4     
+ Partials      459      457       -2
Impacted Files Coverage Δ
plugin/route53/setup.go 82.5% <50%> (+3.67%) ⬆️
plugin/file/reload.go 75% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da2c0c...4669355. Read the comment docs.

Copy link
Collaborator

dilyevsky left a comment

heh, good catch! what the hell, aws?

@miekg miekg merged commit aa96d6b into master Oct 3, 2019
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 55.26% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@corbot corbot bot deleted the drop-init branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.