Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/clouddns: remove initialization from init #3349

merged 2 commits into from Oct 2, 2019


Copy link

miekg commented Oct 2, 2019

Init should just call the plugin.Register with a setup function.

Fixes: #3343

Init should just call the plugin.Register with a setup function.

Fixes: #3343

Signed-off-by: Miek Gieben <>
@miekg miekg requested a review from yongtang Oct 2, 2019
Signed-off-by: Miek Gieben <>

This comment has been minimized.

Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #3349 into master will increase coverage by 0.02%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3349      +/-   ##
+ Coverage   55.22%   55.25%   +0.02%     
  Files         217      217              
  Lines       10788    10785       -3     
+ Hits         5958     5959       +1     
+ Misses       4371     4369       -2     
+ Partials      459      457       -2
Impacted Files Coverage Δ
plugin/clouddns/setup.go 58.92% <20%> (+1.3%) ⬆️
plugin/file/reload.go 75% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da2c0c...cb138d6. Read the comment docs.

Copy link

yongtang left a comment

lgtm, Thanks a lot for the fix!

@yongtang yongtang merged commit 8fde740 into master Oct 2, 2019
5 checks passed
5 checks passed
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
codecov/project 55.25% (target 50%)
continuous-integration/travis-ci/pr The Travis CI build passed
stickler-ci No lint errors found.
@corbot corbot bot deleted the clouddns-init branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.