Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/log: add Clear to stop debug logging #3372

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@miekg
Copy link
Member

miekg commented Oct 13, 2019

When reloading we need to disable debug output when the debug plugin is
removed from the config file. Add a Clear function to pkg/log and use
it in the server server.

Add test case in pkg/log, for actuall check I manually checked the
output by sprinkling some debug statements in the startup and checking
with sending SIGUSR1.

Also clear up the comments in pkg/log to remove the text about time
stamping.

Fixes: #3035

When reloading we need to disable debug output when the debug plugin is
removed from the config file. Add a `Clear` function to pkg/log and use
it in the server server.

Add test case in pkg/log, for actuall check I manually checked the
output by sprinkling some debug statements in the startup and checking
with sending SIGUSR1.

Also clear up the comments in pkg/log to remove the text about time
stamping.

Fixes: #3035

Signed-off-by: Miek Gieben <miek@miek.nl>
@corbot corbot bot requested a review from rajansandeep Oct 13, 2019
@corbot

This comment has been minimized.

Copy link

corbot bot commented Oct 13, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked rajansandeep (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #3372 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3372      +/-   ##
==========================================
+ Coverage   56.27%   56.29%   +0.01%     
==========================================
  Files         218      218              
  Lines       10818    10825       +7     
==========================================
+ Hits         6088     6094       +6     
  Misses       4253     4253              
- Partials      477      478       +1
Impacted Files Coverage Δ
plugin/pkg/log/log.go 76.47% <100%> (+3.13%) ⬆️
core/dnsserver/server.go 11.03% <66.66%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1820c71...136ade9. Read the comment docs.

@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Oct 17, 2019

Copy link
Member

rajansandeep left a comment

/lgtm

@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Oct 17, 2019

thanks

@miekg miekg merged commit 5f114d3 into master Oct 17, 2019
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.29% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@corbot corbot bot deleted the debug-logging branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.