Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parse friendly Normalize #3385

merged 1 commit into from Oct 19, 2019


Copy link

chrisohaver commented Oct 18, 2019

1. Why is this pull request needed and what does it do?

Adds MustNormalize(), which is the same as Normalize() but does not ignore parse errors.
Going forward plugins should prefer MustNormalize() instead of Normalize() when reading parsing the Corefile.

2. Which issues (if any) are related?


3. Which documentation changes (if any) need to be made?


4. Does this introduce a backward incompatible change or deprecation?


@chrisohaver chrisohaver requested a review from miekg Oct 18, 2019
@corbot corbot bot requested a review from bradbeam Oct 18, 2019

This comment has been minimized.

Copy link

corbot bot commented Oct 18, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked bradbeam (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

Signed-off-by: Chris O'Haver <>
@chrisohaver chrisohaver force-pushed the chrisohaver:normalize branch from b51abd3 to c4da47f Oct 18, 2019

This comment has been minimized.

Copy link

miekg commented Oct 19, 2019

thank you

corbot bot approved these changes Oct 19, 2019
Copy link

corbot bot left a comment

LGTM by miekg

@miekg miekg merged commit 6f375cb into coredns:master Oct 19, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.