Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reloading in health and ready #3473

Merged
merged 1 commit into from Nov 20, 2019
Merged

Fix reloading in health and ready #3473

merged 1 commit into from Nov 20, 2019

Conversation

@zouyee
Copy link
Contributor

zouyee commented Nov 20, 2019

Signed-off-by: Zou Nengren zouyee1989@gmail.com

1. Why is this pull request needed and what does it do?

Reloading the server without changing the listen address results in an
error because Startup is called for newly set up plugins before Shutdown
is called for the old ones.

2. Which issues (if any) are related?

a part of #3464
xref #3454

3. Which documentation changes (if any) need to be made?

None

4. Does this introduce a backward incompatible change or deprecation?

None

@corbot corbot bot requested a review from bradbeam Nov 20, 2019
@corbot

This comment has been minimized.

Copy link

corbot bot commented Nov 20, 2019

Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked bradbeam (via /OWNERS) for a review.
Note this is not an exclusive request. Anyone is free to provide a review of this pull request.

If you have questions or suggestions for this bot, please file an issue against the miekg/dreck repository.

The bot understands the commands that are listed here.

@zouyee

This comment has been minimized.

Copy link
Contributor Author

zouyee commented Nov 20, 2019

/assign @miekg

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #3473 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3473   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files         221      221           
  Lines       10992    10992           
=======================================
  Hits         6219     6219           
  Misses       4290     4290           
  Partials      483      483
Impacted Files Coverage Δ
plugin/ready/ready.go 86.2% <100%> (ø) ⬆️
plugin/health/health.go 77.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cae54...ee90686. Read the comment docs.

plugin/health/health.go Outdated Show resolved Hide resolved
@zouyee zouyee force-pushed the zouyee:reuse branch 2 times, most recently from f1abaa4 to 7a648bc Nov 20, 2019
Signed-off-by: zouyee <zounengren@cmss.chinamobile.com>
@zouyee zouyee force-pushed the zouyee:reuse branch from 7a648bc to ee90686 Nov 20, 2019
@miekg

This comment has been minimized.

Copy link
Member

miekg commented Nov 20, 2019

done a bit of minimal manual testing by reloading and curling the health endpoint.
/lgtm

@corbot
corbot bot approved these changes Nov 20, 2019
Copy link

corbot bot left a comment

LGTM by miekg

@miekg miekg merged commit 768ca99 into coredns:master Nov 20, 2019
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.57% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@zouyee zouyee deleted the zouyee:reuse branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.