Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes plugin DNS schema version to 1.1.0 #3554

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@aojea
Copy link
Contributor

aojea commented Dec 19, 2019

1. Why is this pull request needed and what does it do?

The Kubernetes DNS specification schema version was
updated to 1.1.0 in order to support IPv6

2. Which issues (if any) are related?

xref: kubernetes/dns#335

3. Which documentation changes (if any) need to be made?

CoreDNS implements the new Kubernetes DNS 1.1.0 schema with IPv6 support

4. Does this introduce a backward incompatible change or deprecation?

The new schema removes the already deprecated records with format

  • <a>-<b>-<c>-<d>.<ns>.pod.<zone>. <ttl> IN A <a>.<b>.<c>.<d>

kubernetes/dns#335 (comment)

@miekg

This comment has been minimized.

Copy link
Member

miekg commented Dec 19, 2019

tests need to be fixed as well, otherwise lgtm

The Kubernetes DNS specification schema version was
updated to 1.1.0 in order to support IPv6

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@aojea aojea force-pushed the aojea:k8s_schema branch from 5ce0796 to 7035933 Dec 19, 2019
@zouyee

This comment has been minimized.

Copy link
Contributor

zouyee commented Dec 19, 2019

lgtm

@aojea

This comment has been minimized.

Copy link
Contributor Author

aojea commented Dec 19, 2019

tests need to be fixed as well, otherwise lgtm

how can be fixed the circular (😄 )dependency of the circleci job?
forcing to merge coredns/ci#122?

@miekg

This comment has been minimized.

Copy link
Member

miekg commented Dec 19, 2019

@aojea

This comment has been minimized.

Copy link
Contributor Author

aojea commented Dec 19, 2019

ah yes, but travis failed as well (didn't look at that reason), and those tests are fully contained here.

I've updated this PR to fix the travis job failure, travis is passing now with the update.
I've submitted a new PR to fix CircleCI but is failing waiting on this PR :)

@chrisohaver chrisohaver merged commit e1cf9cc into coredns:master Dec 19, 2019
3 of 4 checks passed
3 of 4 checks passed
ci/circleci: kubernetes-tests Your tests failed on CircleCI
Details
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.