Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
plugin/cache: update comment to conform to the implementation #3573
1. Why is this pull request needed and what does it do?
Update comment accordingly to the code fix in 159a8fb
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?
4. Does this introduce a backward incompatible change or deprecation?
@@ Coverage Diff @@ ## master #3573 +/- ## ======================================= Coverage 56.71% 56.71% ======================================= Files 220 220 Lines 11000 11000 ======================================= Hits 6239 6239 Misses 4282 4282 Partials 479 479
ok, how about this: ``` // The Authoritative bit should be set to 0, but some client stub resolver implementations, most notably, // on some legacy systems(e.g. ubuntu 14.04 with glib version 2.20), low-level glibc function `getaddrinfo` // useb by Python/Ruby/etc.. will discard answers that do not have this bit set. // So we're forced to always set this to 1; regardless if the answer came from the cache or not. // On newer systems(e.g. ubuntu 16.04 with glib version 2.23), this issue is resolved. // So we may set this bit back to 0 in the future ? ```
miekg merged commit
Jan 3, 2020
5 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.