Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry cache_miss logic #3578

Merged
merged 1 commit into from Jan 3, 2020
Merged

registry cache_miss logic #3578

merged 1 commit into from Jan 3, 2020

Conversation

@zouyee
Copy link
Contributor

zouyee commented Jan 3, 2020

Signed-off-by: Zou Nengren zouyee1989@gmail.com

1. Why is this pull request needed and what does it do?

registry cache_miss logic

2. Which issues (if any) are related?

#3577

3. Which documentation changes (if any) need to be made?

none

4. Does this introduce a backward incompatible change or deprecation?

none

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #3578 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3578      +/-   ##
==========================================
+ Coverage   56.71%   56.72%   +<.01%     
==========================================
  Files         220      220              
  Lines       11000    11001       +1     
==========================================
+ Hits         6239     6240       +1     
  Misses       4282     4282              
  Partials      479      479
Impacted Files Coverage Δ
plugin/cache/handler.go 85.91% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908508a...6dcc2f9. Read the comment docs.

@zouyee zouyee force-pushed the zouyee:cachemiss branch 5 times, most recently from f6ee522 to e63397a Jan 3, 2020
zouyee
Signed-off-by: zouyee <zounyee1989@gmail.com>
@zouyee zouyee force-pushed the zouyee:cachemiss branch from e63397a to 6dcc2f9 Jan 3, 2020
@miekg
miekg approved these changes Jan 3, 2020
@miekg

This comment has been minimized.

Copy link
Member

miekg commented Jan 3, 2020

12 pending reviewers.. ah, there are no OWNERS for this plugin - oh well.

@miekg miekg merged commit 99e7c3d into coredns:master Jan 3, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.72% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@zouyee zouyee deleted the zouyee:cachemiss branch Jan 3, 2020
@maruina maruina mentioned this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.