Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign: add expiration jitter #3588

Merged
merged 2 commits into from Jan 12, 2020
Merged

sign: add expiration jitter #3588

merged 2 commits into from Jan 12, 2020

Conversation

@miekg
Copy link
Member

miekg commented Jan 12, 2020

This PR adds a expiration jitter to spread out zone re-signing even more.
The max is 5 extra days added when creating the signer for a specific zone.

Also make the duration* constants private to clean up the godoc for this
plugin.

Signed-off-by: Miek Gieben miek@miek.nl

miekg added 2 commits Jan 12, 2020
Signed-off-by: Miek Gieben <miek@miek.nl>
This PR adds a expiration jitter to spread out zone re-signing even
more. The max is 5 extra days added when creating the signer for a
specific zone.

Also make the duration* constants private to clean up the godoc for this
plugin.

Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #3588 into master will decrease coverage by 0.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
- Coverage   56.59%   56.58%   -0.02%     
==========================================
  Files         220      220              
  Lines       11031    11032       +1     
==========================================
- Hits         6243     6242       -1     
- Misses       4310     4311       +1     
- Partials      478      479       +1
Impacted Files Coverage Δ
plugin/sign/sign.go 0% <ø> (ø) ⬆️
plugin/sign/signer.go 55.14% <60%> (ø) ⬆️
plugin/sign/setup.go 62.5% <87.5%> (+0.59%) ⬆️
plugin/errors/errors.go 95.23% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6669de...a7d1f96. Read the comment docs.

@stp-ip
stp-ip approved these changes Jan 12, 2020
Copy link
Member

stp-ip left a comment

/lgtm

Copy link
Collaborator

fastest963 left a comment

LGTM

Copy link
Member

yongtang left a comment

lgtm

@yongtang yongtang merged commit 2221b61 into master Jan 12, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.58% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@yongtang yongtang deleted the more-sign-jitter branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.