Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README and log plugin #3602

Merged
merged 1 commit into from Jan 17, 2020
Merged

docs: update README and log plugin #3602

merged 1 commit into from Jan 17, 2020

Conversation

@miekg
Copy link
Member

miekg commented Jan 17, 2020

README: remove the logo thing as we stopped doing that
log: remote the lines about the clock output as that's gone as well and
discuss the query log vs other logging a bit.

README: remove the logo thing as we stopped doing that
log: remote the lines about the clock output as that's gone as well and
     discuss the query log vs other logging a bit.

Signed-off-by: Miek Gieben <miek@miek.nl>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #3602 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   56.63%   56.62%   -0.01%     
==========================================
  Files         220      220              
  Lines       11039    11039              
==========================================
- Hits         6252     6251       -1     
- Misses       4308     4310       +2     
+ Partials      479      478       -1
Impacted Files Coverage Δ
plugin/forward/connect.go 81.69% <0%> (-4.23%) ⬇️
plugin/file/reload.go 75% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8c325...3170c84. Read the comment docs.

Copy link
Member

chrisohaver left a comment

lgtm

@miekg miekg merged commit c95faea into master Jan 17, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.62% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@miekg miekg deleted the docs branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.