Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/pkg/up: make default intervals shorter #3651

Merged
merged 2 commits into from Feb 6, 2020
Merged

plugin/pkg/up: make default intervals shorter #3651

merged 2 commits into from Feb 6, 2020

Conversation

@miekg
Copy link
Member

miekg commented Feb 4, 2020

I think 15 min is too high, make this lower to react faster.

I think 15 min is too high, make this lower to react faster.

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Feb 4, 2020

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #3651 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3651   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         220      220           
  Lines       11059    11059           
=======================================
  Hits         6266     6266           
  Misses       4311     4311           
  Partials      482      482
Impacted Files Coverage Δ
plugin/pkg/up/up.go 77.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbe4ac...e5db709. Read the comment docs.

Copy link
Member

yongtang left a comment

LGTM

@RickyRajinder

This comment has been minimized.

Copy link
Contributor

RickyRajinder commented Feb 4, 2020

This would also require the README to be updated

@miekg

This comment has been minimized.

Copy link
Member Author

miekg commented Feb 5, 2020

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg requested a review from grobie as a code owner Feb 5, 2020
@miekg miekg merged commit c4fc5cb into master Feb 6, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.65% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@miekg miekg deleted the various branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.