Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/kubernetes: Return all records with matching IP for PTR requests #3687

Merged
merged 1 commit into from Feb 21, 2020

Conversation

@chrisohaver
Copy link
Member

chrisohaver commented Feb 20, 2020

1. Why is this pull request needed and what does it do?

For PTR requests of an Endpoint that has two or more Services pointed to it, provide an answer for each Service. Previously, we were arbitrarily selecting the first one encountered (based on ordering in the index).

2. Which issues (if any) are related?

#3686

3. Which documentation changes (if any) need to be made?

none

4. Does this introduce a backward incompatible change or deprecation?

no

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #3687 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3687      +/-   ##
==========================================
+ Coverage   56.65%   56.67%   +0.01%     
==========================================
  Files         220      220              
  Lines       11059    11060       +1     
==========================================
+ Hits         6266     6268       +2     
+ Misses       4311     4310       -1     
  Partials      482      482
Impacted Files Coverage Δ
plugin/kubernetes/reverse.go 84% <100%> (+0.66%) ⬆️
plugin/file/reload.go 69.44% <0%> (-5.56%) ⬇️
plugin/route53/route53.go 86.61% <0%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1841c...493b977. Read the comment docs.

@miekg miekg merged commit 6ef105c into coredns:master Feb 21, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.67% (target 50%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.