Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/cache: explain drop metric in readme #3706

Merged
merged 1 commit into from Feb 29, 2020

Conversation

@chrisohaver
Copy link
Member

chrisohaver commented Feb 28, 2020

1. Why is this pull request needed and what does it do?

explains what the cache drops metric is about

2. Which issues (if any) are related?

#3697

3. Which documentation changes (if any) need to be made?

this

4. Does this introduce a backward incompatible change or deprecation?

no

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
@chrisohaver chrisohaver requested review from grobie and miekg as code owners Feb 28, 2020
@miekg miekg merged commit 1339b89 into coredns:master Feb 29, 2020
5 checks passed
5 checks passed
DCO DCO
Details
ci/circleci: kubernetes-tests Your tests passed on CircleCI!
Details
codecov/project 56.63% (target 50.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.