Fix a crash in rewrite plugin when rule type is missing #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to fix a crash inrewrite plugin when rule type is missing. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #5459 +/- ##
==========================================
+ Coverage 55.70% 56.93% +1.23%
==========================================
Files 224 235 +11
Lines 10016 14771 +4755
==========================================
+ Hits 5579 8410 +2831
- Misses 3978 5855 +1877
- Partials 459 506 +47
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This PR tries to fix a crash in rewrite plugin when rule type is missing.
2. Which issues (if any) are related?
n/a
3. Which documentation changes (if any) need to be made?
n/a
4. Does this introduce a backward incompatible change or deprecation?
n/a
Signed-off-by: Yong Tang yong.tang.github@outlook.com