Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

#31 : Alternate editor color schemes #42

Merged
merged 2 commits into from Apr 17, 2012

Conversation

Projects
None yet
3 participants
Contributor

aegypius commented Feb 25, 2012

Hi,

First of all, thanks for your amazing work.

Here's my work on alternate color schemes relative to issue #31 from @cmundi. I wrote a basic theme support with cookie storage across sessions.

Comments are welcome !

aegypius added some commits Feb 24, 2012

@aegypius aegypius Add basic editor theme support
This commit need some cleanup and a proper alternate
theme, preference storage and javascript cleanup is needed too.
55631e8
@aegypius aegypius Store preferences in a cookie, code cleanup
- Add jquery.cookie.js to store a preference cookie for 30 days (a .niderc
  maybe a proper solution to store user preferences);
- Create a dialog.html file to avoid html within javascript
- Update styles with dialog related properties
- Update CodeEditor.js to use our stored value when creating new editors
2114483
Owner

coreh commented Apr 17, 2012

Wow, this is such a great addition! Thanks!

I'm sorry for the time it took for me to look into/merge this. Lately I haven't had any time for open source projects like nide due to college.

@coreh coreh added a commit that referenced this pull request Apr 17, 2012

@coreh coreh Merge pull request #42 from aegypius/feature/31-alternate-editor-colo…
…r-schemes


#31 : Alternate editor color schemes
993520e

@coreh coreh merged commit 993520e into coreh-deprecated:master Apr 17, 2012

cmundi commented Apr 18, 2012

Nice commit!

Pesky college. Didn't stop Bill or Steve. All the same, I'm glad I stayed in school. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment