Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed directory structure being sent before being fully built on opening a project #63

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

Kudos for the great work on this project, I'm really impressed. However, there was one little issue that cropped up after I decided to add another structural level to my project, which looked something like so:

./package.json
./responses/file1.json
./responses/file2.json

Simple! The issue was that upon loading the project (by running the 'nide' command in the root directory), the 'responses' directory had been showing as containing no files (i.e. empty). After a bit of debugging it seemed that adding some logging statements to the code responsible for injecting things into the listCache slowed the execution down enough that the files were visible more often than before when repeatedly starting the IDE. Therefore, and after some further investigation, I figured the object was being sent out too quickly -- before it had actually been constructed.

After this change we're now ensuring that the number of processed files equals the number of 'encountered' files before we proceed to dispatch the listCache off to the client. This is serving as an effective fix to the problem I've been able to replicate locally.

[Fix] directory structure being sent before being fully built on init…
…ial project load

Now we're ensuring that the number of 'added' files equals the number
of 'encountered' files before we proceed to dispatch the listCache off
to the client. This is serving as an effective fix to the problem I've
been replicating locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment