Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Conversation

@odarbelaeze
Copy link
Member

Added concrete fields to the article class, extra known info about an article can be found in the extra dict, and also the sources that create the article can be found in sources.

Added two named constructors to the Article class, one would build an article based on a whole ISI record and the other would create it based on a reference.

Now citation_pairs returns Tuple[Article, Article], notice that some of the fields in Article might be None

Now CollectionLazy is totally lazy that means it wouldn't return unique articles and such, there will be a Collection class that deals with unique articles and would hydrate the reference article in citation_pairs.

Copy link
Contributor

@dsvalenciah dsvalenciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odarbelaeze what about add more tests for all new classes?

@odarbelaeze odarbelaeze merged commit 068b7fe into master Aug 8, 2020
@odarbelaeze odarbelaeze deleted the rearchitect/make-stuff-more-concrete branch August 8, 2020 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants