This repository was archived by the owner on Oct 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Making stuff a little bit more concrete #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvalenciah
reviewed
Jun 9, 2020
Contributor
dsvalenciah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@odarbelaeze what about add more tests for all new classes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added concrete fields to the
articleclass, extra known info about an article can be found in theextradict, and also the sources that create the article can be found insources.Added two named constructors to the
Articleclass, one would build an article based on a whole ISI record and the other would create it based on a reference.Now
citation_pairsreturnsTuple[Article, Article], notice that some of the fields inArticlemight beNoneNow
CollectionLazyis totally lazy that means it wouldn't return unique articles and such, there will be aCollectionclass that deals with unique articles and would hydrate the reference article incitation_pairs.