Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.1.3 #269

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@ashcrow
Copy link
Member

commented Sep 11, 2019

At step 4 of release.

Changes

  • cargo: update dependencies (slog, serde, serde_derive, nix, mime)
ashcrow added 2 commits Sep 11, 2019

@ashcrow ashcrow requested review from lucab and bgilbert Sep 11, 2019

@bgilbert
Copy link
Member

left a comment

LGTM

@lucab

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I usually assemble a short list of changes, like in #257.
I think this one only contains dependencies updates, thus just mentioning them as a single entry would be enough: v4.1.2...master

[dev-dependencies]
mockito = "^0.17.1"

[package.metadata.release]

This comment has been minimized.

Copy link
@lucab

lucab Sep 11, 2019

Member

Did you move these sections by hand or did something re-organized them?

This comment has been minimized.

Copy link
@ashcrow

ashcrow Sep 11, 2019

Author Member

cargo release reorganized them

This comment has been minimized.

Copy link
@lucab

lucab Sep 11, 2019

Member

I think it's an unexpected side-effect, I'll check with upstream later.

I checked that there was no functional change except the different order, so we can proceed anyway.

@lucab
lucab approved these changes Sep 11, 2019
Copy link
Member

left a comment

LGTM! @ashcrow do you have permissions to self-merge this?

@ashcrow

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

@lucab I have the power!

@lucab

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@ashcrow feel free to self-merge and continue with the release, at your own pace.

@ashcrow ashcrow merged commit 318855b into coreos:master Sep 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.