Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to clap 4 #817

Merged
merged 1 commit into from Mar 7, 2023
Merged

Update to clap 4 #817

merged 1 commit into from Mar 7, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Oct 18, 2022 •
edited

No description provided.

@bgilbert bgilbert added the msrv Needs newer MSRV label Oct 18, 2022
@bgilbert bgilbert mentioned this pull request Oct 18, 2022
Closed
@prestist prestist mentioned this pull request Oct 25, 2022
Closed
@bgilbert
Copy link
Contributor Author

Filed a Fedora bug that depends on the clap one.

@bgilbert bgilbert removed the msrv Needs newer MSRV label Feb 3, 2023
@bgilbert bgilbert marked this pull request as ready for review February 21, 2023 18:27
@bgilbert
Copy link
Contributor Author

Ready for review!

@bgilbert bgilbert requested review from prestist and removed request for prestist February 27, 2023 19:09
prestist
prestist approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bgilbert bgilbert merged commit 0bd8e5c into coreos:main Mar 7, 2023
9 checks passed
@bgilbert bgilbert deleted the clap branch March 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestist prestist prestist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgilbert @prestist