Skip to content
This repository has been archived by the owner. It is now read-only.

dracut: explicitly order disk-uuid before systemd-fsck-root #78

Merged
merged 1 commit into from Nov 20, 2015

Conversation

@vcaputo
Copy link
Contributor

@vcaputo vcaputo commented Nov 20, 2015

Without this, systemd-fsck-root.service and disk-uuid.service get
started simultaneously when the root disk gets plugged. Then
systemd-fsck-root.service fires again after sgdisk closes the device.

With this, disk-uuid.service runs to completion when the root disk is
plugged, before systemd-fsck-root.service, which not only prevents
potential overlap of execution but also eliminates the double fsck.

Without this, systemd-fsck-root.service and disk-uuid.service get
started simultaneously when the root disk gets plugged.  Then
systemd-fsck-root.service fires *again* after sgdisk closes the device.

With this, disk-uuid.service runs to completion when the root disk is
plugged, before systemd-fsck-root.service, which not only prevents
potential overlap of execution but also eliminates the double fsck.
@crawford
Copy link
Member

@crawford crawford commented Nov 20, 2015

LGTM

With the patch, 5/5 machine succeeded to reformat the root. Without, 2/5 machines succeeded.

crawford added a commit that referenced this pull request Nov 20, 2015
…_fsck-root

dracut: explicitly order disk-uuid before systemd-fsck-root
@crawford crawford merged commit 2251fc9 into coreos:master Nov 20, 2015
@marineam
Copy link
Contributor

@marineam marineam commented Nov 20, 2015

FYI, likely also fixed by: systemd/systemd#1875

sigh

@vcaputo
Copy link
Contributor Author

@vcaputo vcaputo commented Nov 21, 2015

sigh indeed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.