New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: explicitly order disk-uuid before systemd-fsck-root #78

Merged
merged 1 commit into from Nov 20, 2015

Conversation

Projects
None yet
3 participants
@vcaputo
Contributor

vcaputo commented Nov 20, 2015

Without this, systemd-fsck-root.service and disk-uuid.service get
started simultaneously when the root disk gets plugged. Then
systemd-fsck-root.service fires again after sgdisk closes the device.

With this, disk-uuid.service runs to completion when the root disk is
plugged, before systemd-fsck-root.service, which not only prevents
potential overlap of execution but also eliminates the double fsck.

dracut: explicitly order disk-uuid before systemd-fsck-root
Without this, systemd-fsck-root.service and disk-uuid.service get
started simultaneously when the root disk gets plugged.  Then
systemd-fsck-root.service fires *again* after sgdisk closes the device.

With this, disk-uuid.service runs to completion when the root disk is
plugged, before systemd-fsck-root.service, which not only prevents
potential overlap of execution but also eliminates the double fsck.
@crawford

This comment has been minimized.

Member

crawford commented Nov 20, 2015

LGTM

With the patch, 5/5 machine succeeded to reformat the root. Without, 2/5 machines succeeded.

crawford added a commit that referenced this pull request Nov 20, 2015

Merge pull request #78 from vcaputo/explicitly_order_disk-uuid_before…
…_fsck-root

dracut: explicitly order disk-uuid before systemd-fsck-root

@crawford crawford merged commit 2251fc9 into coreos:master Nov 20, 2015

@marineam

This comment has been minimized.

Contributor

marineam commented Nov 20, 2015

FYI, likely also fixed by: systemd/systemd#1875

sigh

@vcaputo

This comment has been minimized.

Contributor

vcaputo commented Nov 21, 2015

sigh indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment