Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/e2e-update: do not rebuild binaries #184

Closed
wants to merge 1 commit into from

Conversation

lucab
Copy link
Contributor

@lucab lucab commented May 3, 2021

Avoid rebuilding the project from source, as binaries have already
been built in previous steps.

Avoid rebuilding the project from source, as binaries have already
been built in previous steps.
@lucab
Copy link
Contributor Author

lucab commented May 3, 2021

This still fails in CI but in a different way (possibly due to copying binaries across different environments):

+ install_uefi
+ /usr/bin/bootupctl backend install --src-root=/tmp/rootfs/ostree/deploy/fedora-coreos/deploy/3cff9961aa0aec9c34db5cfb341f35c40be181d67c2814a89ca6c364b55ea729.0 /tmp/rootfs

/usr/bin/bootupctl: /lib64/libc.so.6: version `GLIBC_2.33' not found (required by /usr/bin/bootupctl)

@cgwalters
Copy link
Member

This has the same problem as coreos/rpm-ostree#2806 (comment)

IOW with this PR we silently stop testing the PR code at build time. I think I'd prefer to wait for f34 cosa and leave CI broken rather than silently testing half of things.

@lucab
Copy link
Contributor Author

lucab commented May 4, 2021

Ack, feel free to take over with the proper fix for this.

@lucab lucab closed this May 4, 2021
@lucab lucab deleted the ups/tests-e2e-fix branch May 4, 2021 13:30
@bgilbert bgilbert mentioned this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants