New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizing / breaks /dev/disk/by-partlabel/ROOT #1527

Closed
mischief opened this Issue Aug 18, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@mischief

mischief commented Aug 18, 2016

using extend-filesystems.service results in /dev/disk/by-partlabel/ROOT going missing. the partition information is also missing from blkid -o -p /dev/vda9.

running partx -u after e.g. cgpt resize/resize2fs seems to fix the partition information and partlabel symlink.

@vcaputo vcaputo self-assigned this Aug 22, 2016

@vcaputo

This comment has been minimized.

vcaputo commented Aug 22, 2016

I'll poke a bit at this...

@crawford

This comment has been minimized.

Member

crawford commented Aug 27, 2016

@mischief I heard you uncovered some interesting behavior from cgpt.

@mischief

This comment has been minimized.

mischief commented Aug 27, 2016

@crawford yes, running cgpt resize /dev/vda9 (or whatever ROOT is) is what causes the bug. extend-filesystems.service is basically doing that.

@crawford

This comment has been minimized.

Member

crawford commented Aug 27, 2016

@dm0- was telling me that cgpt wrote a new partlabel to the kernel but didn't persist it to disk, which is why partx (which reads the label from the disk) fixes the information.

@vcaputo

This comment has been minimized.

vcaputo commented Aug 27, 2016

ah, I didn't poke at this yet, sounds like dm0 has identified the probable root cause though. So we've got a cgpt bug to fix here?

@vcaputo

This comment has been minimized.

vcaputo commented Aug 30, 2016

for posterity: this turned out to simply be an off by one error in the cgpt resize code.

crawford added a commit to crawford/coreos-overlay that referenced this issue Sep 6, 2016

crawford added a commit to crawford/coreos-overlay that referenced this issue Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment