toolbox does not work on 1151.0.0

[monder]

Issue Report

Bug

Toolbox does not launch.

CoreOS Version

NAME=CoreOS
ID=coreos
VERSION=1151.0.0
VERSION_ID=1151.0.0
BUILD_ID=2016-08-25-0937
PRETTY_NAME="CoreOS 1151.0.0 (MoreOS)"
ANSI_COLOR="1;32"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"

Environment

AWS (ami-ee65149d)

Expected Behavior

$ toolbox
Spawning container core-fedora-latest on /var/lib/toolbox/core-fedora-latest.
Press ^] three times within 1s to kill container.
[root@ip-10-0-1-8 ~]#

Actual Behavior

$ toolbox
latest: Pulling from library/fedora
2bf01635e2a0: Pull complete
Digest: sha256:64a02df6aac27d1200c2572fe4b9949f1970d05f74d367ce4af994ba5dc3669e
Status: Downloaded newer image for fedora:latest
4b12d1a5062c8d28300801f564b22f6603df15fa02af200b774651fd46470773
core-fedora-latest
Spawning container core-fedora-latest on /var/lib/toolbox/core-fedora-latest.
Press ^] three times within 1s to kill container.
Invalid bind mount option: /media/root/usr --bind=/run:/media/root/run

Other Information

TOOLBOX_BIND="--bind=/:/media/root --bind=/usr:/media/root/usr --bind=/run:/media/root/run"

But in /usr/bin/toolbox this environment variable is passed as a single argument:

sudo systemd-nspawn \
        --directory="${machinepath}" \
        --capability=all \
        --share-system \
        "${TOOLBOX_BIND}" \
        --user="${TOOLBOX_USER}" "$@"

Shouldn't it be:

sudo systemd-nspawn \
        --directory="${machinepath}" \
        --capability=all \
        --share-system \
        ${TOOLBOX_BIND} \
        --user="${TOOLBOX_USER}" "$@"

without quotes.

[jonboulle]

fixed upstream but needs an image bump

[crawford]

Fixed via coreos/coreos-overlay#2152.