New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship an updated etcdctl #1717

Closed
brianredbeard opened this Issue Dec 16, 2016 · 5 comments

Comments

Projects
None yet
6 participants
@brianredbeard
Member

brianredbeard commented Dec 16, 2016

Issue Report

Please ship an updated etcdctl as it includes support for both API versions via the ETCDCTL_API variable.

@crawford

This comment has been minimized.

Show comment
Hide comment
@crawford

crawford Mar 20, 2017

Member

We are going to hold off on this until etcd0 has been removed from the OS (May 7th). Then we can easily bump to the latest v2 binary and not have to worry about backward compatibility.

Member

crawford commented Mar 20, 2017

We are going to hold off on this until etcd0 has been removed from the OS (May 7th). Then we can easily bump to the latest v2 binary and not have to worry about backward compatibility.

@dm0-

This comment has been minimized.

Show comment
Hide comment
@dm0-

dm0- May 17, 2017

Member

The last alpha shipped the etcd2 version of etcdctl.

Member

dm0- commented May 17, 2017

The last alpha shipped the etcd2 version of etcdctl.

@dm0- dm0- closed this May 17, 2017

@crawford

This comment has been minimized.

Show comment
Hide comment
@crawford

crawford May 17, 2017

Member

We actually need the v3 version of etcdctl. This will support both v3 and v2. Since we are going to be removing etcd2 early next year, I think we should instead ship etcd and etcdctl together, independent of the OS. Right now, it's looking like torcx will be the answer to this. That will allow users to install whichever version of etcd they'd like and get a matching etcd and etcdctl.

Member

crawford commented May 17, 2017

We actually need the v3 version of etcdctl. This will support both v3 and v2. Since we are going to be removing etcd2 early next year, I think we should instead ship etcd and etcdctl together, independent of the OS. Right now, it's looking like torcx will be the answer to this. That will allow users to install whichever version of etcd they'd like and get a matching etcd and etcdctl.

@shamalco

This comment has been minimized.

Show comment
Hide comment
@shamalco

shamalco Jun 28, 2017

Is there yet an expect time period or release for this enhancement ?

shamalco commented Jun 28, 2017

Is there yet an expect time period or release for this enhancement ?

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

dev-db/etcd: add etcdctl useflag
This paves the way to including the etcdctl binary from another package.

See coreos/bugs#1717 for some context around
this.

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

dev-db/etcd: add etcdctl useflag
This paves the way to including the etcdctl binary from another package.

See coreos/bugs#1717 for some context around
this.

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

dev-db/etcd: add etcdctl useflag
This paves the way to including the etcdctl binary from another package.

See coreos/bugs#1717 for some context around
this.

As discussed on that issue, a long term solution here might be torcx.

However, I don't think we need to actually wait for torcx to do this
since the etcd3 cli is meant to be perfectly backwards compatible.

This will also allow our docs around using `etcd-member.service` to be
more readable/usable, since right now the docs don't have an easy way to
talk to the etcd cluster from a Contaienr Linux machine.

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

dev-db/etcdctl: add etcdctl v3 package
This complements dev-db/etcd with USE="-etcdctl"

See coreos/bugs#1717 for the motivation for
providing etcdctl as a separate package with a newer version.

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

coreos-base/coreos: use etcdctl v3
See the commit message introducing that package for the full story.
See also coreos/bugs#1717

euank added a commit to euank/coreos-overlay that referenced this issue Aug 21, 2017

coreos-base/coreos: use etcdctl v3
See the two previous commit messages for more details.
See also coreos/bugs#1717

@euank euank self-assigned this Aug 21, 2017

@dm0-

This comment has been minimized.

Show comment
Hide comment
@dm0-

dm0- Aug 25, 2017

Member

This is merged for the next alpha in coreos/coreos-overlay#2720.

Member

dm0- commented Aug 25, 2017

This is merged for the next alpha in coreos/coreos-overlay#2720.

@dm0- dm0- closed this Aug 25, 2017

ChrisMcKenzie added a commit to ChrisMcKenzie/coreos-overlay that referenced this issue Dec 9, 2017

dev-db/etcd: add etcdctl useflag
This paves the way to including the etcdctl binary from another package.

See coreos/bugs#1717 for some context around
this.

As discussed on that issue, a long term solution here might be torcx.

However, I don't think we need to actually wait for torcx to do this
since the etcd3 cli is meant to be perfectly backwards compatible.

This will also allow our docs around using `etcd-member.service` to be
more readable/usable, since right now the docs don't have an easy way to
talk to the etcd cluster from a Contaienr Linux machine.

ChrisMcKenzie added a commit to ChrisMcKenzie/coreos-overlay that referenced this issue Dec 9, 2017

dev-db/etcdctl: add etcdctl v3 package
This complements dev-db/etcd with USE="-etcdctl"

See coreos/bugs#1717 for the motivation for
providing etcdctl as a separate package with a newer version.

ChrisMcKenzie added a commit to ChrisMcKenzie/coreos-overlay that referenced this issue Dec 9, 2017

coreos-base/coreos: use etcdctl v3
See the two previous commit messages for more details.
See also coreos/bugs#1717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment