New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motdgen depends on locksmithd, blocking user logins #1774

Closed
llamahunter opened this Issue Jan 25, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@llamahunter

llamahunter commented Jan 25, 2017

Issue Report

Bug

CoreOS Version

NAME=CoreOS
ID=coreos
VERSION=1185.5.0
VERSION_ID=1185.5.0
BUILD_ID=2016-12-07-0937
PRETTY_NAME="CoreOS 1185.5.0 (MoreOS)"
ANSI_COLOR="1;32"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"

Environment

AWS and Openstack

Expected Behavior

User is able to log in to node even if locksmithd has not run (i.e. it is being held off so that it doesn't release its cluster reboot lock until the current node comes back up in a known good state).

Actual Behavior

User is unable to log in because locksmithd is before motdgen which is before a whole bunch of stuff necessary for users to be able to log in.

Reproduction Steps

  1. Configure a systemd unit to hold off the start of locksmithd for an indefinite period
  2. Boot up the node
  3. Try to log in via ssh

Other Information

Feature Request

Environment

See above

Desired Feature

motdgen.service is not listed as depending on locksmithd.service

Other Information

Alternatively, some way to let locksmithd come up normally, but provide a hook to not release its software update reboot lock until given some all clear signal.

@crawford

This comment has been minimized.

Show comment
Hide comment
@crawford

crawford Feb 24, 2017

Member

Now that Ignition exists, we have a deterministic way of deciding the reboot strategy before the message of the day is generated. It's probably time we strip all of that timer logic from motdgen.

Member

crawford commented Feb 24, 2017

Now that Ignition exists, we have a deterministic way of deciding the reboot strategy before the message of the day is generated. It's probably time we strip all of that timer logic from motdgen.

@crawford

This comment has been minimized.

Show comment
Hide comment
@crawford
Member

crawford commented Mar 22, 2017

@crawford crawford closed this Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment