Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
1423.0.0 AWS no instance ssh key #1981
Container Linux Version
I can ssh to instance using the key specified in AWS
Instance asks for a password.
Create a machine with with ignition config (From my experiments- it does not matter whats inside)
Try to ssh.
@monder good catch, thanks for the report! I can confirm this is a regression in 1423.0.0 due to coreos-metadata 0.10.0.
For reference, the service responsible for populating ssh keys is
Here is the log from a failed instance:
Paging @dgonyeo to have a look into this.
From my perspective there are a bunch of issues here:
@lucab I made a PR to fix this, and on your comments:
I'm not sure which fetches in here are unnecessary. Each piece of metadata lives at a different endpoint in the metadata service. I can remove unnecessary calls if you can explain a little more
A 404 is expected if the user has not configured an SSH key, so this error is swallowed. I'll see if I can find a way to differentiate between "no ssh keys" and "there's a legitimate error".
But this specific flag only takes care of the ssh key, so why re-fetching everything? Or maybe not and I misunderstood how this was designed to work.
Ah, having a single status for empty and missing endpoint is unfortunate.
Oh I see what you're talking about with the extra fetches. Fixing that would require rearchitecting coreos-metadata, since there's the single