Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
OEM configs are hardcoded in Ignition #2004
OEM-specific configs are currently hardcoded in Ignition. Move them to files in the OEM partition, and provide a way for the OS to signal Ignition that it should read an additional config file there.
@crawford The options as I see them:
I'm currently pursuing approach 3, but it's not entirely pretty. Thoughts?
Hmm, I'm stuck between 2 and 3. On one hand, I think 2 works very well for our system since we know that configs will always come from one of two locations (depending on whether or not we are PXE booting). On the other, 3 is much more flexible and allows others to potentially pull base configs from network locations.
I'm not clear on downside 1 though. I thought the resource code unmounted right after reading the file. As for downside 2, can't we use conditional drop-ins that key on
referenced this issue
Nov 16, 2017
Downside 1 is just an objection to mounting and unmounting the OEM partition once for each file we read from it. As to downside 2, we could use conditional dropins, but that also seems kind of hacky.
I've now abandoned option 3 as too complex. coreos/ignition#475 implements the Ignition part of option 2.