Skip to content
This repository has been archived by the owner. It is now read-only.

Enable Track memory changes #2048

Closed
hamann opened this issue Jul 10, 2017 · 2 comments
Closed

Enable Track memory changes #2048

hamann opened this issue Jul 10, 2017 · 2 comments

Comments

@hamann
Copy link

@hamann hamann commented Jul 10, 2017

Issue Report

Feature Request

Environment

All

Desired Feature

Please enable Track memory changes (CONFIG_MEM_SOFT_DIRTY), which is necessary to make incremental dumps with criu

@lucab
Copy link
Member

@lucab lucab commented Jul 11, 2017

I was a bit concerned with the performance impact of this, so for reference I found the following statement in the initial patchset description:

As long as soft dirty bits are not cleared, no performance
penalty occur, since the soft dirty bit and the regular dirty bit are set at 
the same time within the same instruction. When soft dirty is cleared via 
clear_refs, the task in question might slow down, but it will depend on how
actively it uses the memory.
@bgilbert
Copy link
Member

@bgilbert bgilbert commented Jul 26, 2017

This is done in coreos/coreos-overlay#2663, which should be included in 1492.0.0.

@bgilbert bgilbert closed this Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.