New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Track memory changes #2048

Closed
hamann opened this Issue Jul 10, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@hamann

hamann commented Jul 10, 2017

Issue Report

Feature Request

Environment

All

Desired Feature

Please enable Track memory changes (CONFIG_MEM_SOFT_DIRTY), which is necessary to make incremental dumps with criu

@lucab

This comment has been minimized.

Show comment
Hide comment
@lucab

lucab Jul 11, 2017

Member

I was a bit concerned with the performance impact of this, so for reference I found the following statement in the initial patchset description:

As long as soft dirty bits are not cleared, no performance
penalty occur, since the soft dirty bit and the regular dirty bit are set at 
the same time within the same instruction. When soft dirty is cleared via 
clear_refs, the task in question might slow down, but it will depend on how
actively it uses the memory.
Member

lucab commented Jul 11, 2017

I was a bit concerned with the performance impact of this, so for reference I found the following statement in the initial patchset description:

As long as soft dirty bits are not cleared, no performance
penalty occur, since the soft dirty bit and the regular dirty bit are set at 
the same time within the same instruction. When soft dirty is cleared via 
clear_refs, the task in question might slow down, but it will depend on how
actively it uses the memory.
@bgilbert

This comment has been minimized.

Show comment
Hide comment
@bgilbert

bgilbert Jul 26, 2017

Member

This is done in coreos/coreos-overlay#2663, which should be included in 1492.0.0.

Member

bgilbert commented Jul 26, 2017

This is done in coreos/coreos-overlay#2663, which should be included in 1492.0.0.

@bgilbert bgilbert closed this Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment