New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsck never runs on the ESP #2245

Closed
bgilbert opened this Issue Nov 10, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@bgilbert
Member

bgilbert commented Nov 10, 2017

Issue Report

Bug

Container Linux Version

$ cat /etc/os-release
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1590.0.0+2017-11-09-0113
VERSION_ID=1590.0.0
BUILD_ID=2017-11-09-0113
PRETTY_NAME="Container Linux by CoreOS 1590.0.0+2017-11-09-0113 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"

Environment

Any

Expected Behavior

fsck is run on the ESP when necessary.

Actual Behavior

fsck never runs on OS filesystems other than /. On every subsequent boot after an unclean shutdown, the kernel says:

[   38.087266] FAT-fs (vda1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.

Reproduction Steps

  1. Forcibly power off the system.
  2. Boot and check dmesg.

Other Information

/usr/share/oem is journaled, so there's less of a problem in that case. /boot is not journaled.

The fix should be as simple as adding a dependency to boot.mount in init.

@bgilbert

This comment has been minimized.

Show comment
Hide comment
@bgilbert
Member

bgilbert commented Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment