New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #477 in the 2.0.x release branch #630

Open
databus23 opened this Issue Sep 27, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@databus23
Copy link
Contributor

databus23 commented Sep 27, 2018

Description of Problem / Feature Request

We just run into #441. The issue has been fixed with #477 almost a year ago in master.

Can we please backport this so that this issue is mitigated in production deployments? It should not introduce any incompatibilities or functional changes (besides that the container doesn't create thousands of zombies anymore.)

Expected Outcome

No zombies

Actual Outcome

Zombies!

Environment

  • Clair version/image: v2.0.4
  • Clair client name/version: N/A
  • Host OS: CoreOS
  • Kernel (e.g. uname -a): 4.14.48-coreos-r2
  • Kubernetes version (use kubectl version): 1.7.5
  • Helm version (use helm version): 1.10
  • Network/Firewall setup: N/A
@wdoekes

This comment has been minimized.

Copy link

wdoekes commented Sep 27, 2018

If you're going to fix old builds, might as well remove this annoying "true" printed to stdout:

https://github.com/coreos/clair/blob/v2.0.4/api/v1/models.go#L246

😎

@wdoekes

This comment has been minimized.

Copy link

wdoekes commented Sep 27, 2018

.. and you'll want to cherry-pick 9e4a347.

@potzkovge

This comment has been minimized.

Copy link

potzkovge commented Dec 11, 2018

While it was fixed in master(#477) (See: https://engineeringblog.yelp.com/2016/01/dumb-init-an-init-for-docker.html) You can fix it in docker-compose v2 with init: true as described here: https://docs.docker.com/compose/compose-file/compose-file-v2/#init
For v3 it is discussed here: docker/compose#5049

So a working docker-compose v2 example would be:

version: "2"
services:
  clair:
    image: quay.io/coreos/clair:v2.0.2
    init: true
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment