Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an overrides/patches/$srpm directory #470

Open
jlebon opened this issue Apr 8, 2019 · 0 comments
Open

Support an overrides/patches/$srpm directory #470

jlebon opened this issue Apr 8, 2019 · 0 comments

Comments

@jlebon
Copy link
Member

@jlebon jlebon commented Apr 8, 2019

A major part of hacking on the OS is being able to test patches. Right now this is a very manual process with e.g. fedpkg local on the side and then copying into overrides/rpm (or sending them to an existing VM and doing override replace). It'd be cool if we could do e.g.:

$ mkdir -p overrides/patches/ignition
$ (cd overrides/patches/ignition && curl -L https://github.com/coreos/ignition-dracut/pull/60.patch)
$ cosa build
Building ignition locally with override patches...
...

This would: download the SRPM, unpack it, apply the patch, rpmdev-bumpspec, build, and add the built RPMs to the overrides/rpm dir. Would be easier to require the container image to be based on the same buildroot though so we don't have to use mock. This is the case for FCOS at least :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.