Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-ore-wrapper: fix using basename to auto-detect command #1042

Merged
merged 3 commits into from Jan 13, 2020

Conversation

@jlebon
Copy link
Member

jlebon commented Jan 13, 2020

We were using startswith() directly on argv[0] to know which symlink
we were called as, but that might be the full path to the script. So
pass through basename() first.

Closes: #1039

jlebon added 3 commits Jan 13, 2020
We were using `startswith()` directly on `argv[0]` to know which symlink
we were called as, but that might be the full path to the script. So
pass through `basename()` first.

Closes: #1039
We were auto-detecting `replicate` commands via the symlink used, but
not actually passing it through to argparse. I/the pipeline didn't
actually hit this yet, just noticed it while here.
Make it clear that these variables are about setting the defaults in the
new interface via the old symlinks.
@jlebon jlebon force-pushed the jlebon:pr/fix-aws branch from ef3b10e to f619ed1 Jan 13, 2020
Copy link
Member

cgwalters left a comment

Only superficially checked, seems sane.

@darkmuggle

This comment has been minimized.

Copy link
Contributor

darkmuggle commented Jan 13, 2020

LGTM. Merge when ready.

@darkmuggle

This comment has been minimized.

Copy link
Contributor

darkmuggle commented Jan 13, 2020

Interesting...when I was doing the testing, I was using the cosa buildextend... interface, as opposed to cmd-buildextend.

Copy link
Member

ashcrow left a comment

LGTM

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Jan 13, 2020

Once continuous-integration/jenkins/pr-merge returns merge at will.

@jlebon jlebon merged commit 637cc00 into coreos:master Jan 13, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jlebon jlebon deleted the jlebon:pr/fix-aws branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.