Skip to content

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Jan 28, 2020

The rationale for this is that it's a different "kind" of test, and so
it shouldn't clobber the results of a previous cosa kola run
invocation. It also makes it easier to run in parallel with it.

We only want to add the default value if it wasn't provided.
The rationale for this is that it's a different "kind" of test, and so
it shouldn't clobber the results of a previous `cosa kola run`
invocation. It also makes it easier to run in parallel with it.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit 695f17b into coreos:master Jan 28, 2020
@jlebon jlebon deleted the pr/kola-upgrade-tweak branch January 28, 2020 20:11
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants