cmd/run: Use sysctl.d dropin instead of service #128
Conversation
|
Let's label this WIP until it merges in ignition and makes it into fedora |
dustymabe
changed the title
|
This one should be good to go now that the sysctl patch was backported! |
jlebon
changed the title
|
assigned myself as reviewer |
| { | ||
| "filesystem": "root", | ||
| "path": "/etc/sysctl.d/10-coreos.conf", | ||
| "contents": { "source": "data:,kernel.printk%20=%203%204%201%207%0A" }, |
There was a problem hiding this comment.
really dumb question. It's ascii encoded and not base64 encoded. Is there a tool you use for that? for base64 it's easy with base64 cli utility.
There was a problem hiding this comment.
I wrote it by hand like a caveman. :) I do prefer URL encoding for smaller strings like this since you can kinda make it out still. With base64 you basically have to pass it through to understand it. In this case, I'm open to just dynamically calling base64 if you prefer.
There was a problem hiding this comment.
haha no no.. I was just wondering if there was an actual tool you used because I felt like I should know of one.
| "storage": { | ||
| "files": [ | ||
| { | ||
| "filesystem": "root", |
There was a problem hiding this comment.
wish we could have comments in json files so we could explain why we did this without looking back at git history.
|
LGTM! |
Requires: coreos/ignition#639