Skip to content

Simplify add-root-cas script and rename #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

Simplify add-root-cas script and rename #3037

merged 1 commit into from
Aug 15, 2022

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Aug 15, 2022

Don't support passing a directory containing root CA certs to copy.
Default to just updating the bundles like update-ca-trust does.
Accordingly, rename to update-ca-trust-unpriv.

@jlebon
Simplify add-root-cas script and rename
88d2973 
Don't support passing a directory containing root CA certs to copy.
Default to just updating the bundles like `update-ca-trust` does.
Accordingly, rename to `update-ca-trust-unpriv`.
@jlebon
Copy link
Member Author

jlebon commented Aug 15, 2022

Prow flaked on network, but CI doesn't test this anyway.
/override ci/prow/images
/override ci/prow/rhcos

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/images, ci/prow/rhcos

In response to this:

Prow flaked on network, but CI doesn't test this anyway.
/override ci/prow/images
/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters
cgwalters approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon jlebon merged commit f53bc8f into coreos:main Aug 15, 2022
@travier travier mentioned this pull request Sep 15, 2022
Closed
28 tasks
@mike-nguyen
Copy link
Member

mike-nguyen commented Sep 15, 2022

/cherry-pick rhcos-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 15, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 15, 2022

@mike-nguyen: new pull request created: #3107

In response to this:

/cherry-pick rhcos-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon deleted the pr/rename-add-root-cas branch April 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jlebon @mike-nguyen @openshift-cherrypick-robot @cgwalters