WIP: remove anaconda #311

ajeddeloh · 2019-02-04T17:22:51Z

Very rough atm

dustymabe · 2019-02-04T17:25:38Z

I asked andrew if he could post this. very much a WIP so hold off on deep review

dustymabe · 2019-02-05T04:24:06Z

two items identified by andrew as holding up this work:

1 - ostreedev/ostree#1774 - so we don't have to hardcode a grub config (for now). I've asked robert to take a look.
2 - making sure firstboot processes don't run - it seems anaconda does the right thing here, but since we aren't using anaconda we need to make sure we disable whatever mechanism is causing it to start in the ostree itself. We should be able to add something to our postprocess in the manifest.yaml.

rfairley · 2019-02-15T19:17:21Z

Built a few ostree RPMs that can be used for dev purposes for now:
f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=32835828
f29: https://koji.fedoraproject.org/koji/taskinfo?taskID=32835841
f30: https://koji.fedoraproject.org/koji/taskinfo?taskID=32835878

These RPMs are built from the tree at https://github.com/rfairley/ostree/commits/rfairley-bls-config-dev-rpm.

I have tested the f29 RPM on Fedora Atomic Host 29. Executing the commands in this comment should now work to avoid the hardcoded grub config part.

The RPMs ostree and ostree-libs should be installed - the other RPMs being optional. On F29AH I did this:

curl --remote-name-all https://kojipkgs.fedoraproject.org//work/tasks/5842/32835842/ostree-2019.1.16.g98b27889-5.fc29.x86_64.rpm https://kojipkgs.fedoraproject.org//work/tasks/5842/32835842/ostree-libs-2019.1.16.g98b27889-5.fc29.x86_64.rpm
rpm-ostree override replace ostree-*

Running the same ostree commands as used in this PR, but with the following appended to rootfs/ostree/repo/config, should avoid running into the assertion in ostreedev/ostree#1774 (comment).

# in rootfs/ostree/repo/config:
[sysroot]
bootloader=none


        bottlecap: drop privs, add --net=host


        src/cmd-init: drop anaconda bits


        src/cmdlib.sh: drop anaconda bits


        src/vmdeps.txt: add tools for building images


        src/cmlib: add bits for creawking disk images

ajeddeloh · 2019-02-18T23:20:32Z

@dustymabe updated to be in sync with latest-ish master. Got a lot of hacks still in there. metal-{bios/uefi} are not implemented yet. doesn't use the new ostree bits yet. but you can build an image and play with anaconda (will need to edit the grub config to not mask the unit via kernel command line).


        src/*: switch to using bash script to build iamges

dustymabe · 2019-02-19T03:32:19Z

thanks @ajeddeloh !

cgwalters · 2019-02-19T21:35:25Z

src/cmd-build

-iso_location="${workdir}/installer/$(basename "${INSTALLER}")"
-checksum_location="${workdir}/installer/$(basename "${INSTALLER_CHECKSUM}")"
+	rm -f "$(pwd)/diskimage.raw"
+	truncate -s 8G "$(pwd)/diskimage.raw"


Let's get the size from image.yaml.

Do we parse image.yaml into anything readable by bash anywhere?

cgwalters · 2019-02-19T21:35:25Z

src/create_disk.sh

+# HACK ALERT - wait for partition rescans
+sleep 2
+# FIXME ostree needs symlinks
+mkfs.ext2 "$(getpart ${disk} 1)" -L boot


cgwalters · 2019-02-19T21:35:25Z

src/create_disk.sh

+# FIXME ostree needs symlinks
+mkfs.ext2 "$(getpart ${disk} 1)" -L boot
+mkfs.fat "$(getpart ${disk} 2)" -n EFI-SYSTEM
+mkfs.xfs "$(getpart ${disk} 4)"  -L root


Currently we also force on -m reflink=1 but eh...I guess we can just take that default from mkfs in the near future.

cgwalters · 2019-02-19T21:35:25Z

src/create_disk.sh

+ostree admin init-fs rootfs
+ostree pull-local "$ostree" --repo rootfs/ostree/repo
+ostree admin os-init fedora-coreos --sysroot rootfs
+ostree admin deploy "$ref" --sysroot rootfs --os fedora-coreos


The fedora-coreos values are ${name} in cmd-build.sh.

cgwalters · 2019-02-19T21:35:25Z

src/create_disk.sh

+checksum=$(cat rootfs/boot/ostree/*/{vm*,init*} | sha256sum | cut -d ' ' -f 1)
+vmlinuz=$(basename  rootfs/boot/ostree/*/vm*)
+initrd=$(basename rootfs/boot/ostree/*/init*)
+echo "Checksum is: $checksum initrd is $initrd vmlinuz is $vmlinuz"


This data is more canonically stored in the BLS fragment.

cgwalters · 2019-02-19T21:35:25Z

src/grub.cfg

+insmod xfs
+set root='hd0,gpt1'
+set hash="HASHHASH"
+linux16 /ostree/fedora-coreos-${hash}/VMLINUZ no_timer_check console=tty0 console=ttyS0,115200n8 net.ifnames=0 biosdevname=0 ip=dhcp rd.neednet=1 rw $ignition_firstboot root=LABEL=root ostree=/ostree/boot.1/fedora-coreos/${hash}/0 coreos.oem.id=qemu systemd.mask=systemd-firstboot.service


Yeah, definitely better to use the data from the BLS here right?

Still working on getting that working, but yeah that's the idea at least for the time being

cgwalters · 2019-03-01T14:14:47Z

Since #380 landed as promised I'm happy to do the rebase of this PR myself - do you have any outstanding changes?

nhorman · 2019-03-20T13:03:25Z

@cgwalters if you can rebase, I can pull this in

nullr0ute · 2019-04-18T09:06:21Z

Fedora IoT still uses anaconda support in in rpm-ostree and related because of the status of certain required HW support. I'm not sure how this relates to assembler but please be aware of other consumers and ensure coordination.

ajeddeloh · 2019-04-18T15:49:36Z

@nullr0ute this is just for COSA, which is only used for building FCOS/RHCOS. Anaconda support will remain in rpm-ostree.

cgwalters · 2019-04-22T21:18:11Z

@nullr0ute this is just for COSA, which is only used for building FCOS/RHCOS.

Right, though personally I'd like to at least have COSA used to build Silverblue and other things.

Anaconda support will remain in rpm-ostree.

Technically it's the inverse, Anaconda supports rpm-ostree via rpmostreepayload.py; I don't personally see us adding many new features but I will certainly personally help maintain the code and fix bugs if any important ones come up.

ajeddeloh · 2019-06-14T21:39:50Z

Closing in favor of a much less stale #556

ajeddeloh added 5 commits Feb 18, 2019

bottlecap: drop privs, add --net=host

85192cc

src/cmd-init: drop anaconda bits

9a0917e

src/cmdlib.sh: drop anaconda bits

31a5aee

src/vmdeps.txt: add tools for building images

81e2093

src/cmlib: add bits for creawking disk images

cb6e7c6

ajeddeloh force-pushed the ajeddeloh:bottlecap branch from 2bb8556 to 85a9557 Feb 18, 2019

src/*: switch to using bash script to build iamges

Loading status checks…

1103d6d

ajeddeloh force-pushed the ajeddeloh:bottlecap branch from 85a9557 to 1103d6d Feb 18, 2019

cgwalters reviewed Feb 19, 2019

View changes

cgwalters mentioned this pull request Apr 17, 2019

Support default kernel arguments #479

Open

bgilbert added this to In Progress in Fedora CoreOS preview via automation May 17, 2019

ajeddeloh closed this Jun 14, 2019

bgilbert removed this from In Progress in Fedora CoreOS preview Jun 18, 2019

coreos / coreos-assembler

WIP: remove anaconda #311

WIP: remove anaconda #311

ajeddeloh commented Feb 4, 2019

This comment has been minimized.

dustymabe commented Feb 4, 2019

This comment has been minimized.

dustymabe commented Feb 5, 2019

This comment has been minimized.

rfairley commented Feb 15, 2019 •

edited

This comment has been minimized.

ajeddeloh commented Feb 18, 2019

This comment has been minimized.

dustymabe commented Feb 19, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cgwalters commented Mar 1, 2019

This comment has been minimized.

nhorman commented Mar 20, 2019

This comment has been minimized.

nullr0ute commented Apr 18, 2019

This comment has been minimized.

ajeddeloh commented Apr 18, 2019

This comment has been minimized.

cgwalters commented Apr 22, 2019

This comment has been minimized.

ajeddeloh commented Jun 14, 2019

coreos / coreos-assembler

Join GitHub today

WIP: remove anaconda #311

WIP: remove anaconda #311

Conversation

ajeddeloh commented Feb 4, 2019

This comment has been minimized.

dustymabe commented Feb 4, 2019

This comment has been minimized.

dustymabe commented Feb 5, 2019

This comment has been minimized.

rfairley commented Feb 15, 2019 • edited

This comment has been minimized.

ajeddeloh commented Feb 18, 2019

This comment has been minimized.

dustymabe commented Feb 19, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cgwalters commented Mar 1, 2019

This comment has been minimized.

nhorman commented Mar 20, 2019

This comment has been minimized.

nullr0ute commented Apr 18, 2019

This comment has been minimized.

ajeddeloh commented Apr 18, 2019

This comment has been minimized.

cgwalters commented Apr 22, 2019

This comment has been minimized.

ajeddeloh commented Jun 14, 2019

rfairley commented Feb 15, 2019 •

edited