New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop FAHC #337

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
5 participants
@cgwalters
Copy link
Member

cgwalters commented Feb 8, 2019

The FAHC stream was absolutely critical when coreos-assembler
was actively driving fixes/development in rpm-ostree. Today
that isn't the case as much. While I think we should
still ship git master rpm-ostree in cosa, we don't need to do
so right at this moment. We can wait until we solve
coreos/fedora-coreos-tracker#84

Closes: #336

@dustymabe
Copy link
Collaborator

dustymabe left a comment

LGTM. will merge shortly unless anyone has objections.

Show resolved Hide resolved build.sh
build: Drop FAHC, Ignition COPR
The FAHC stream was absolutely critical when coreos-assembler
was actively driving fixes/development in rpm-ostree.  Today
that isn't the case as much.  While I think we should
still ship git master rpm-ostree in cosa, we don't need to do
so right at this moment.  We can wait until we solve
coreos/fedora-coreos-tracker#84

And we don't need the Ignition COPR right now.
(Although IMO it would make sense to add Ignition to FAHC but
 that's a distinct thing)

Closes: #336

@cgwalters cgwalters force-pushed the cgwalters:drop-fahc branch from 2440fa3 to 287e0e9 Feb 8, 2019

@cgwalters

This comment has been minimized.

Copy link
Member Author

cgwalters commented Feb 8, 2019

OK updated and now tested that this at least depsolves.

@jlebon

jlebon approved these changes Feb 8, 2019

@dustymabe

This comment has been minimized.

Copy link
Collaborator

dustymabe commented Feb 8, 2019

This LGTM but I'd like @miabbott or @ashcrow to merge. I think we did some things in our EL7 implementation that considered the exclude would get added and I'd like to confirm things don't break.

@dustymabe dustymabe requested a review from miabbott Feb 8, 2019

@ashcrow

This comment has been minimized.

Copy link
Collaborator

ashcrow commented Feb 8, 2019

Will review shortly

@ashcrow

This comment has been minimized.

Copy link
Collaborator

ashcrow commented Feb 8, 2019

I think this is fine. I am seeing an error with a maipo build where old version of rpm-ostree is being used (rather than the latest stable) but I believe that to be unrelated.

@ashcrow

ashcrow approved these changes Feb 8, 2019

@miabbott

This comment has been minimized.

Copy link
Contributor

miabbott commented Feb 8, 2019

This LGTM but I'd like @miabbott or @ashcrow to merge. I think we did some things in our EL7 implementation that considered the exclude would get added and I'd like to confirm things don't break.

I think trying to get an EL7 cosa has resulted in a lot of pain without a lot of payoff. I'm fine for merging this and abandoning our EL7 efforts here to focus on EL8.

@jlebon jlebon merged commit 9043d16 into coreos:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment