From 678f102662bbd6a209a22dcd6c36fe99dff46330 Mon Sep 17 00:00:00 2001 From: Dusty Mabe Date: Wed, 13 Aug 2025 22:47:53 -0400 Subject: [PATCH] cmd-osbuild: add comment for relevance of rootful codepath This came up in the prior code review [1] and we agreed to add the comment as a followon PR. [1] https://github.com/coreos/coreos-assembler/pull/4251#discussion_r2273583462 --- src/cmd-osbuild | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cmd-osbuild b/src/cmd-osbuild index 23862ceb22..b3594584f8 100755 --- a/src/cmd-osbuild +++ b/src/cmd-osbuild @@ -398,7 +398,10 @@ main() { outdir=$(mktemp -p "${tmp_builddir}" -d) if has_privileges && [ "${COSA_NO_KVM:-}" == "1" ]; then - cmd="env" # run outside of supermin if we are root already + # Run outside of supermin if we are root already. This is useful + # mostly on riscv where /dev/kvm isn't really supported by any + # hardware right now (2025/08). + cmd="env" else cmd="runvm_with_cache" fi