Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcmdlib: Accept CAP_SYS_ADMIN in bounding set #457
Merged
Conversation
I'm switching my devel environment to https://github.com/debarshiray/toolbox/ and I think having CAP_SYS_ADMIN in the Current set was just a bug in my `podman` scripts. We really want to check the bounding set. It was a pleasant surprise that `cosa build` worked just fine here, including the recursive containerization from `bwrap`.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cgwalters commentedApr 1, 2019
I'm switching my devel environment to https://github.com/debarshiray/toolbox/
and I think having CAP_SYS_ADMIN in the Current set was just a bug in my
podmanscripts. We really want to check the bounding set.It was a pleasant surprise that
cosa buildworked just fine here,including the recursive containerization from
bwrap.