blockdev: use --nodeps when querying single device #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
reviewed
Jan 15, 2021
Functionally equivalent. Prep for next patch.
`lsblk` by default outputs the target device followed by all its reverse dependencies. But interestingly, when using `--pairs`, the `lsblk` in RHCOS seems to output the reverse dependency first before the target device. We were relying on correct ordering in `lsblk_single`, where all we care about is the target device. Instead, explicitly use `--nodeps` in that case so that `lsblk` knows to only print the target device. (The `lsblk()` helper actually used to support that, but it was removed in 88de4fc.) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1916502
One clarification on this: it seems like in some cases, RHEL's |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Mar 18, 2021
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Mar 18, 2021
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 19, 2021
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Mar 19, 2021
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453 (cherry picked from commit 5228316)
miabbott
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 22, 2021
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453 (cherry picked from commit 5228316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsblkby default outputs the target device followed by all its reversedependencies. But interestingly, when using
--pairs, thelsblkinRHCOS seems to output the reverse dependency first before the target
device.
We were relying on correct ordering in
lsblk_single, where all we careabout is the target device. Instead, explicitly use
--nodepsin thatcase so that
lsblkknows to only print the target device. (Thelsblk()helper actually used to support that, but it was removed in88de4fc.)
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1916502