Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/libvirt: add libvirt provider using eth0 as network iface #79

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jforman
Copy link

jforman commented Dec 25, 2017

Based on the virtualbox provider, but using eth0 instead.

@jforman jforman changed the title initial addition: libvirt provide using eth0 as network interface add libvirt provider using eth0 as network int Dec 25, 2017

@jforman jforman changed the title add libvirt provider using eth0 as network int providers/libvirt: add libvirt provider using eth0 as network iface Dec 25, 2017

@jforman

This comment has been minimized.

Copy link
Author

jforman commented Dec 25, 2017

I'm trying to get the tailor tests to pass, but not quite sure which part of my request is making it fail (even with the reasons provided). Any help greatly appreciated.

@crawford

This comment has been minimized.

Copy link
Member

crawford commented Dec 25, 2017

The scope can't have spaces. I would use "providers/libvirt" in this case. Your commit also needs a description after the title.

The rules can be found here: https://github.com/coreos/coreos-metadata/blob/master/.github/tailor.yaml

jforman added some commits Dec 25, 2017

initial addition: libvirt provide using eth0 as network interface
Running coreos on libvirt (ubuntu) on bare-metal, the default
network interface is eth0, not eth1 as in use by other
bare-metal providers (vagrant-virtualbox). This provider mirrors
that provider almost exactly, just s/eth1/eth0/g.
providers/libvirt: add libvirt provider using eth0 as network iface
Running coreos on libvirt (ubuntu) on bare-metal, the default
network interface is eth0, not eth1 as in use by other
bare-metal providers (vagrant-virtualbox). This provider mirrors
that provider almost exactly, just s/eth1/eth0/g.
providers/libvirt: add libvirt provider using eth0 as network iface
running coreos on libvirt (ubuntu) on bare-metal, the default
network interface is eth0, not eth1 as in use by other
bare-metal providers (vagrant-virtualbox). This provider mirrors
that provider almost exactly, just s/eth1/eth0/g.

@jforman jforman closed this Dec 25, 2017

@jforman

This comment has been minimized.

Copy link
Author

jforman commented Dec 25, 2017

@crawford Yep, just saw it now. Thanks!

@jforman

This comment has been minimized.

Copy link
Author

jforman commented Dec 25, 2017

Following along to close the loop, this PR has been superseded by PR #81 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.