Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oem-exoscale: make DHCP address retrieval more resilient #1893

Merged
merged 1 commit into from Apr 25, 2016

Conversation

Projects
None yet
4 participants
@vincentbernat
Copy link
Contributor

vincentbernat commented Apr 19, 2016

When retrievent the DHCP IP address (to get user data), two steps were
used: the first one waited for one lease file to become present and the
second one extracted and validated the server IP address. If for some
reason the second step failed, an empty IP was provided (and notably,
coreos-setup-environment.service never finishes correctly).

To avoid that, we combine the two steps into a loop: for each available
lease file, extract the IP and validate it. If it succeeds, return
it. If not continue. If nothing was found, restart the same process
after sleeping a bit.

@coreosbot

This comment has been minimized.

Copy link

coreosbot commented Apr 19, 2016

Can one of the admins verify this patch?

@marineam

This comment has been minimized.

Copy link
Contributor

marineam commented Apr 21, 2016

LGTM, could you bump the version of the ebuild please?

oem-exoscale: make DHCP address retrieval more resilient
When retrievent the DHCP IP address (to get user data), two steps were
used: the first one waited for one lease file to become present and the
second one extracted and validated the server IP address. If for some
reason the second step failed, an empty IP was provided (and notably,
coreos-setup-environment.service never finishes correctly).

To avoid that, we combine the two steps into a loop: for each available
lease file, extract the IP and validate it. If it succeeds, return
it. If not continue. If nothing was found, restart the same process
after sleeping a bit.

@vincentbernat vincentbernat force-pushed the exoscale:fix/exoscale-dhcp branch from e967c4b to 8ee6dd5 Apr 21, 2016

@vincentbernat

This comment has been minimized.

Copy link
Contributor Author

vincentbernat commented Apr 21, 2016

Done.

@sebgoa

This comment has been minimized.

Copy link
Contributor

sebgoa commented Apr 21, 2016

#1901 is the same but for the generic cloudstack build

@marineam

This comment has been minimized.

Copy link
Contributor

marineam commented Apr 25, 2016

LGTM, thanks!

@marineam marineam merged commit 49b8de4 into coreos:master Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.