Is it necessary to avoid setting ETCD_UNSUPPORTED_ARCH=riscv64 #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
reviewed
Dec 3, 2021
| @@ -465,6 +465,7 @@ func checkSupportArch() { | |||
| // to add a new platform, check https://github.com/etcd-io/website/blob/main/content/en/docs/next/op-guide/supported-platform.md | |||
There was a problem hiding this comment.
Please update the link to: https://etcd.io/docs/v3.5/op-guide/supported-platform.
It requires adding CI test for build to make it tier-3 'unstable' platform.
Personally I think we should keep warning for any setup that is not "Tier 1 or 2".
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add
runtime.GOARCH == "riscv64"to avoid setting ETCD_UNSUPPORTED_ARCH=riscv64.